Comments on: Friday Algorithms: JavaScript Merge Sort

By: Boya Jiang

Boya Jiang — Tue, 31 Oct 2017 06:56:01 +0000

Chris is absolutely right, it is expensive to shift as the time complexity for array insertion is O(n). Stoimen has written very clean and concise code, but sacrifices speed. It’s faster to have a pointer on each of the array halves, and push the array with the higher value, while iterating that pointer.

By: Chris Reeve

Chris Reeve — Fri, 10 Feb 2017 19:06:33 +0000

This code works fine for small and medium-sized inputs, but it may not complete for far larger arrays. Probably has to do with all of the shifts …

By: Anthony

Anthony — Thu, 15 Sep 2016 20:24:56 +0000

evenb: It’s removing the zeroth element from the right array and putting it into the result array

By: Paloma

Paloma — Tue, 13 Sep 2016 13:29:39 +0000

Wouldn’t be better to do an array concat instead of iterate the rest of the positions? I mean for this part:

while (left.length)
result.push(left.shift());

By: evan b

evan b — Mon, 08 Feb 2016 14:49:41 +0000

Quick question, the part where you push right.shift() into the array. What is this part doing?